Reset Remote on Assert commands #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that we get a true value for the argument when passed in as a flag to the `assert` command
- Assert subparser now accepts `reset-remote` as a valid argument - Pass `remote-reset` arg to the runner before validating data tests
Keeping things styled nicely
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
=========================================
+ Coverage 63.75% 63.8% +0.04%
=========================================
Files 9 9
Lines 756 757 +1
=========================================
+ Hits 482 483 +1
Misses 274 274
Continue to review full report at Codecov.
|
joshtemple
approved these changes
Dec 2, 2019
There was a problem hiding this comment.
This looks great, thanks @msandt3 and congrats on your first Python PR! Will wait for Dylan's review but expecting we'll be merging this today.
DylanBaker
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a logical extension of #95 . We use a dedicated API user, so missing out on tests in the head of the branch is something we'd like to rectify. There is some risk of bricking your Looker user's branch if that's how you choose to use Spectacles.
My first PR in python - feedback appreciated.